Call dynamic class hook on generic classes#16052
Merged
sobolevn merged 1 commit intopython:masterfrom Sep 19, 2023
Merged
Conversation
sobolevn
approved these changes
Sep 5, 2023
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
LGTM! Thanks!
Let's wait for one more review, because we are clearly very opinioned about this feature :)
Author
Yes indeed, we're quite biased here |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
approved these changes
Sep 18, 2023
Member
|
Congrats @flaeppe on your first mypy contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8359
CC @sobolevn
get_dynamic_class_hook()will now additionally be called for generic classes with parameters. e.g.